fix: KeyError in accuracyIndicators() when weightDict is a column subset#277
Open
FBumann wants to merge 1 commit intoFZJ-IEK3-VSA:developfrom
Open
fix: KeyError in accuracyIndicators() when weightDict is a column subset#277FBumann wants to merge 1 commit intoFZJ-IEK3-VSA:developfrom
FBumann wants to merge 1 commit intoFZJ-IEK3-VSA:developfrom
Conversation
…olumns accuracyIndicators() iterated over all columns in normalizedTimeSeries but accessed weightDict[column] without checking membership. This caused a KeyError when apply() was used with data containing columns not in the original weights. Use .get(column, 1) to default unweighted columns. Closes FZJ-IEK3-VSA#276 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
FBumann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accuracyIndicators()raisedKeyErrorwhenweightDictdidn't contain all columns in the data (e.g. whenapply()is used with extra columns).get(column, 1)instead of[column]so unweighted columns default to weight 1Closes #276
Test plan
KeyErrortest_apply_with_weights_and_extra_columnspasses🤖 Generated with Claude Code